This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Fixes #212: ensure pact path is consistent - #213
Open
solarmosaic-kflorence wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #212 -- it seems that when given a
new File(relativePath),file.createNewFile()will create a file in a different place for SBT sub-projects and root-projects. Usingnew File(absolutePath)instead resolves this issue.I'm not sure the best way to add test coverage for this, but it can be reproduced by:
.enablePlugins(ScalaPactPlugin).sbt pactTest, assuming you.aggregatethe sub-project in the root project)target/pactsfolder, as well as insubProject/target/pactsprior to this fix, and after this fix they should both be in the roottarget/pactsfolder.