Local Reviews (via API and Croissant)#12425
Open
pdurbin wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
Croissant
Closed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // "maxValue": 10 | ||
| // } | ||
| // }, | ||
| // ] |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
File contains tab characters (this is the first instance).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to support local reviews, which is when a review dataset points at a regular dataset and both are in the same installation of Dataverse.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Create a dataset like this:
Then, create a review dataset that points to the dataset like this:
Then try the new "list reviews" API endpoint.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Preview at https://dataverse-guide--12327.org.readthedocs.build/en/12327/api/native-api.html#list-reviews
In the image below (source) ReviewDataset2 is a local review: