update tests for the MyData api fix#451
Open
ChengShi-1 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
FY26 Sprint 24
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the client’s integration and functional test suites for the MyData API behavior change where “no results” responses are now treated as successful (empty) results instead of errors (Issue #450, aligned with Dataverse PR IQSS/dataverse#12256).
Changes:
- Adjusts MyData-related tests to expect empty
MyDataCollectionItemSubsetresults instead ofReadErrors when filters yield no results. - Improves integration test setup/teardown robustness by using a unique MyData user and guarding cleanup steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/integration/collections/CollectionsRepository.test.ts | Updates MyData integration test setup/cleanup and changes expectations from error-on-empty to empty-subset success. |
| test/functional/collections/GetMyDataCollectionItems.test.ts | Reworks functional tests to assert empty-subset success across “no results” scenarios and updates related assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+123
to
+125
| const actualCollectionPreview = actual.items[0] as CollectionPreview | ||
| expect(actualCollectionPreview.alias).toBe(testCollectionAlias) | ||
|
|
Comment on lines
154
to
157
| } catch (error) { | ||
| readError = error as ReadError | ||
| } finally { | ||
| expect(readError).toBeInstanceOf(ReadError) | ||
| expect(readError?.message).toEqual( | ||
| 'There was an error when reading the resource. Reason was: Sorry, no results were found.' | ||
| ) | ||
| console.log(error) | ||
| throw new Error('Item subset should be retrieved') | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
Additional documentation: