Apply configured CXXFLAGS to Python bindings#25
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Applies the project's configured CXXFLAGS (via $(AM_CXXFLAGS)) to the Python binding library targets so warning, debug, and optimization flags are propagated to their compile commands, while preserving the existing Python include paths.
Changes:
- Prepend
$(AM_CXXFLAGS)tolibpy3neurosim_la_CXXFLAGS. - Prepend
$(AM_CXXFLAGS)tolibpy2neurosim_la_CXXFLAGS. - Prepend
$(AM_CXXFLAGS)to the versionlesslibpyneurosim_la_CXXFLAGS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$(AM_CXXFLAGS)in all Python binding target CXXFLAGSVerification
./autogen.sh./configure --with-python=3make V=1git diff --checkThe patched Python binding compile and link commands now include
-W -Wall -pedantic -Wno-long-long -g -O3.Addresses #4.