Skip to content

Apply configured CXXFLAGS to Python bindings#25

Open
pragnyanramtha wants to merge 1 commit into
INCF:masterfrom
pragnyanramtha:fix-python-binding-cxxflags-4
Open

Apply configured CXXFLAGS to Python bindings#25
pragnyanramtha wants to merge 1 commit into
INCF:masterfrom
pragnyanramtha:fix-python-binding-cxxflags-4

Conversation

@pragnyanramtha
Copy link
Copy Markdown

@pragnyanramtha pragnyanramtha commented May 13, 2026

Summary

  • include $(AM_CXXFLAGS) in all Python binding target CXXFLAGS
  • preserve existing Python include paths while applying configured warning, debug, and optimization flags
  • keep the default core library build unchanged

Verification

  • ./autogen.sh
  • ./configure --with-python=3
  • make V=1
  • git diff --check

The patched Python binding compile and link commands now include -W -Wall -pedantic -Wno-long-long -g -O3.

Addresses #4.

Copilot AI review requested due to automatic review settings May 13, 2026 23:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies the project's configured CXXFLAGS (via $(AM_CXXFLAGS)) to the Python binding library targets so warning, debug, and optimization flags are propagated to their compile commands, while preserving the existing Python include paths.

Changes:

  • Prepend $(AM_CXXFLAGS) to libpy3neurosim_la_CXXFLAGS.
  • Prepend $(AM_CXXFLAGS) to libpy2neurosim_la_CXXFLAGS.
  • Prepend $(AM_CXXFLAGS) to the versionless libpyneurosim_la_CXXFLAGS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants