Skip to content

Update obsolete Autotools macros#24

Open
pragnyanramtha wants to merge 1 commit into
INCF:masterfrom
pragnyanramtha:fix/autotools-obsolete-macros
Open

Update obsolete Autotools macros#24
pragnyanramtha wants to merge 1 commit into
INCF:masterfrom
pragnyanramtha:fix/autotools-obsolete-macros

Conversation

@pragnyanramtha
Copy link
Copy Markdown

Fixes #11

Summary

  • Replace obsolete Autotools macros in configure.ac with current equivalents.
  • Replace obsolete AC_TRY_LINK checks in the local MPI detection macro with AC_LINK_IFELSE.
  • Keep the change limited to existing Autotools input files.

Root cause

The build configuration still used macros that modern Autoconf reports as obsolete, including AM_CONFIG_HEADER, AC_AIX, AC_LANG_CPLUSPLUS, AC_PROG_LIBTOOL, and AC_TRY_LINK.

Files changed

  • acinclude.m4
  • configure.ac

Tests run

  • git diff --check
  • autoreconf -fi -W obsolete,error in a throwaway copy
  • ./configure --without-python in a throwaway copy
  • make -j2 in a throwaway copy

Risk

Low. The updates use Autoupdate-recommended macro replacements and preserve the same MPI link-test logic.

Copilot AI review requested due to automatic review settings May 13, 2026 19:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes obsolete Autotools macros to resolve issue #11 while preserving the existing build configuration behavior.

Changes:

  • Replaces deprecated Autoconf/Automake macros in configure.ac with current equivalents.
  • Converts MPI link checks in acinclude.m4 from AC_TRY_LINK to AC_LINK_IFELSE.
  • Keeps updates limited to Autotools input files.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
configure.ac Updates obsolete Autotools macros and removes redundant libtool initialization.
acinclude.m4 Modernizes MPI link-test macros without changing detection logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsolete Autotools m4s used

2 participants