Skip to content

Added pyincore-data NSI example notebook#450

Merged
ywkim312 merged 12 commits into
developfrom
444-create-an-example-notebook-for-nsi-data-to-building-inventory-conversion-with-some-analysis
Jul 21, 2025
Merged

Added pyincore-data NSI example notebook#450
ywkim312 merged 12 commits into
developfrom
444-create-an-example-notebook-for-nsi-data-to-building-inventory-conversion-with-some-analysis

Conversation

@ywkim312

@ywkim312 ywkim312 commented May 5, 2025

Copy link
Copy Markdown
Member

To test this, please install pyincore-data's develop branch to your test environment (e.g., your local machine) first.

@navarroc

navarroc commented Jun 18, 2025

Copy link
Copy Markdown
Member

I would suggest putting this example notebook in our tutorials page: https://tools.in-core.org/doc/incore/tutorials.html. Also, we might want to expand this notebook a little to show using the parser to fetch the data for one county and write it to a shapefile or geopackage. Also, we should put some headers so the notebook looks nicer like our other tutorials. You could even add a step to show posting the inventory to the IN-CORE service, but I would choose something small (e.g. seaside or similar).

…ta-to-building-inventory-conversion-with-some-analysis
@navarroc

Copy link
Copy Markdown
Member

@ywkim312 Can you link to this new tutorial somewhere from the documentation? I would put it in the Tutorials section (tutorials.md) or at least the Examples section (notebook_other.md). Tutorials would likely get more visibility and this is a good tutorial to get started with NSI data.

@navarroc

Copy link
Copy Markdown
Member

Just some comments for next week - I think we can remove the nsi_test.gpkg file, right? We don't need that in the repository. Also, we need to run the NSI notebook and save the output cells so it gets rendered in the docs.

@ywkim312

Copy link
Copy Markdown
Member Author

I would suggest putting this example notebook in our tutorials page: https://tools.in-core.org/doc/incore/tutorials.html. Also, we might want to expand this notebook a little to show using the parser to fetch the data for one county and write it to a shapefile or geopackage. Also, we should put some headers so the notebook looks nicer like our other tutorials. You could even add a step to show posting the inventory to the IN-CORE service, but I would choose something small (e.g. seaside or similar).

Everything has been added except the posting the inventory to service. Maybe, we can add this later after the incore-service for this is up and running

@ywkim312

Copy link
Copy Markdown
Member Author

Just some comments for next week - I think we can remove the nsi_test.gpkg file, right? We don't need that in the repository. Also, we need to run the NSI notebook and save the output cells so it gets rendered in the docs.

no, we need the file to show the direct conversion of geopackage to nsi inventory. If we remove the gpkg file, we need to remove the cell that does this in the notebook.

@navarroc

Copy link
Copy Markdown
Member

Just some comments for next week - I think we can remove the nsi_test.gpkg file, right? We don't need that in the repository. Also, we need to run the NSI notebook and save the output cells so it gets rendered in the docs.

no, we need the file to show the direct conversion of geopackage to nsi inventory. If we remove the gpkg file, we need to remove the cell that does this in the notebook.

We should follow the same pattern we do with the other tutorials. We create a zip of all the files needed to run the tutorial and that goes in the "notebooks" folder (see create_local_hazard.zip) and then in the tutorials section, we put just the notebook where we've ran it so the output is displayed in the documentation. The notebook in the zip should have cleared output.

@navarroc

Copy link
Copy Markdown
Member

I would suggest putting this example notebook in our tutorials page: https://tools.in-core.org/doc/incore/tutorials.html. Also, we might want to expand this notebook a little to show using the parser to fetch the data for one county and write it to a shapefile or geopackage. Also, we should put some headers so the notebook looks nicer like our other tutorials. You could even add a step to show posting the inventory to the IN-CORE service, but I would choose something small (e.g. seaside or similar).

Everything has been added except the posting the inventory to service. Maybe, we can add this later after the incore-service for this is up and running

I don't understand. The output of the notebook is a local building dataset (shapefiles). You can add another cell to show uploading it to the service as a building dataset. I didn't meant using the new NSI endpoint.

@ywkim312

Copy link
Copy Markdown
Member Author

@ywkim312 Can you link to this new tutorial somewhere from the documentation? I would put it in the Tutorials section (tutorials.md) or at least the Examples section (notebook_other.md). Tutorials would likely get more visibility and this is a good tutorial to get started with NSI data.

Added this to tutorial along with the zip file

@navarroc

Copy link
Copy Markdown
Member

Just some comments for next week - I think we can remove the nsi_test.gpkg file, right? We don't need that in the repository. Also, we need to run the NSI notebook and save the output cells so it gets rendered in the docs.

no, we need the file to show the direct conversion of geopackage to nsi inventory. If we remove the gpkg file, we need to remove the cell that does this in the notebook.

We should follow the same pattern we do with the other tutorials. We create a zip of all the files needed to run the tutorial and that goes in the "notebooks" folder (see create_local_hazard.zip) and then in the tutorials section, we put just the notebook where we've ran it so the output is displayed in the documentation. The notebook in the zip should have cleared output.

Nevermind, I was wrong. We have been including the data too with the tutorials.

…ta-to-building-inventory-conversion-with-some-analysis
@navarroc

Copy link
Copy Markdown
Member

Can you clear the output from the jupyter notebook in the zip file?

@ywkim312

Copy link
Copy Markdown
Member Author

Can you clear the output from the jupyter notebook in the zip file?

Oh, so this one shouldn't have results? I removed them and pushed.

Comment thread manual_jb/content/tutorials.md Outdated
@ywkim312
ywkim312 merged commit 1f9f34a into develop Jul 21, 2025
1 check passed
@ywkim312
ywkim312 deleted the 444-create-an-example-notebook-for-nsi-data-to-building-inventory-conversion-with-some-analysis branch July 21, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an example notebook for NSI data to building inventory conversion with some analysis

2 participants