Fixes/tls in comm thread#440
Merged
Merged
Conversation
bosilca
approved these changes
Nov 2, 2022
| } | ||
|
|
||
| ret = __parsec_context_wait( context->virtual_processes[0]->execution_streams[0] ); | ||
| ret = __parsec_context_wait( parsec_my_execution_stream() ); |
Contributor
There was a problem hiding this comment.
While technically correct, this change hides the fact that this is in parsec_context_wait, a function that should only be called from the main user thread (aka. context->virtual_processes[0]->execution_streams[0]).
| gettimeofday(&tv_now, NULL); | ||
|
|
||
| PARSEC_TLS_SET_SPECIFIC(parsec_tls_execution_stream, es); | ||
| parsec_set_my_execution_stream(es); |
Contributor
There was a problem hiding this comment.
The only reason we need the parsec_set_my_execution_stream accessor is because parsec_tls_execution_stream is defined as static, and therefore not visible outside the parsec.c file. I think that where the symbols are visible, the uses of the TLS macros should be encouraged.
…p_mpi_on directly from the main thread. In this case, we should not change the TLS of the calling thread to point to the comm engine pseudo-execution stream
therault
force-pushed
the
fixes/tls_in_comm_thread
branch
from
e811659 to
8fbfb62
Compare
abouteiller
approved these changes
Nov 2, 2022
devreal
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an assert that triggers in debug noisier/paranoid mode after #422
Also remove a warning about unused variable in scheduling.c