Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ac9ddf2
Ruff up pyds8k
NjM3MjY5NzAgNzA3MzA3 Apr 24, 2025
97e0b9e
Lint E713
NjM3MjY5NzAgNzA3MzA3 Apr 24, 2025
d999489
Ruff format
NjM3MjY5NzAgNzA3MzA3 Apr 25, 2025
66c0e34
Lint I
NjM3MjY5NzAgNzA3MzA3 Apr 25, 2025
b8a89da
Lint PIE
NjM3MjY5NzAgNzA3MzA3 Apr 25, 2025
cf791f2
Lint PYI
NjM3MjY5NzAgNzA3MzA3 Apr 25, 2025
f28d2a8
Lint EM
NjM3MjY5NzAgNzA3MzA3 May 8, 2025
48c11d4
Lint RET
NjM3MjY5NzAgNzA3MzA3 May 8, 2025
4e9eff8
Lint RSE
NjM3MjY5NzAgNzA3MzA3 May 8, 2025
78fe48c
Lint SIM
NjM3MjY5NzAgNzA3MzA3 May 8, 2025
54c794a
Lint TID
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
e891591
Lint PGH
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
3f69826
Lint PL
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
376e821
Use HTTPStatus codes
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
d7706a9
Ignore PLW0603 for now.
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
e9809c6
Lint FURB
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
7874e1e
Lint DTZ
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
ea8fc17
Lint A
NjM3MjY5NzAgNzA3MzA3 May 9, 2025
20d9dbb
Lint UP
NjM3MjY5NzAgNzA3MzA3 May 17, 2025
9babbce
Lint UP008
NjM3MjY5NzAgNzA3MzA3 May 17, 2025
da3962f
Lint PTH
NjM3MjY5NzAgNzA3MzA3 May 19, 2025
e7b27eb
Lint C4
NjM3MjY5NzAgNzA3MzA3 May 20, 2025
1ad3d55
Lint PT
NjM3MjY5NzAgNzA3MzA3 May 20, 2025
f549c87
Lint PERF
NjM3MjY5NzAgNzA3MzA3 May 20, 2025
c39f749
Lint PL
NjM3MjY5NzAgNzA3MzA3 Jun 24, 2025
5896fb5
Lint EXE
NjM3MjY5NzAgNzA3MzA3 Jun 24, 2025
67fb4fd
Lint B
NjM3MjY5NzAgNzA3MzA3 Jun 24, 2025
698238e
Lint N
NjM3MjY5NzAgNzA3MzA3 Jun 25, 2025
18549e8
Lint RUF
NjM3MjY5NzAgNzA3MzA3 Jun 25, 2025
699cd77
Lint TRY
NjM3MjY5NzAgNzA3MzA3 Jun 25, 2025
b53da7c
Lint BLE
NjM3MjY5NzAgNzA3MzA3 Jun 26, 2025
5b3285d
Lint C90
NjM3MjY5NzAgNzA3MzA3 Jun 26, 2025
d034fb0
Lint the rest
NjM3MjY5NzAgNzA3MzA3 Jun 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup Python
uses: actions/setup-python@v4
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Run Ruff Lint
uses: astral-sh/ruff-action@v3
with:
python-version: "3.12"
- name: Install tox and any other packages
run: |
pip install tox
- name: Run tox
run: tox -e flake8
src: "./pyds8k"
- name: Run Ruff Format
uses: astral-sh/ruff-action@v3
with:
args: "format --check --diff"
src: "./pyds8k"

unit_test:
runs-on: ${{ matrix.os }}
Expand Down
1 change: 1 addition & 0 deletions pyds8k/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
:module: pyds8k

"""

PYDS8K_DEFAULT_LOGGER = "pyds8k"

version_tuple = (1, 6, 0)
Expand Down
4 changes: 1 addition & 3 deletions pyds8k/auth/authenticate.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,5 @@


def get_authenticate(service_type, service_version):
auth_module = import_module(
'{0}.{1}.{2}.auth'.format(__package__, service_type, service_version)
)
auth_module = import_module(f'{__package__}.{service_type}.{service_version}.auth')
return auth_module.Auth
13 changes: 5 additions & 8 deletions pyds8k/auth/ds8k/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@
DEFAULT_BASE_URL = ''


class Auth(object):

class Auth:
base_url = DEFAULT_BASE_URL
auth_url = AUTH_URL

def __init__(self):
pass

@classmethod
def authenticate(self, client):
def authenticate(cls, client):
"""
The main authenticate method. Mandatory
"""
Expand All @@ -40,21 +39,19 @@ def authenticate(self, client):
if client.hostname:
params['hmc1'] = client.hostname
req_p = RequestParser(params)
_, body = client.post(self.get_auth_url(),
body=req_p.get_request_data()
)
_, body = client.post(cls.get_auth_url(), body=req_p.get_request_data())
token = _get_data(body).get('token', '')
if token:
client.set_defaultHeaders('X-Auth-Token', token)
# client.set_defaultQuerystrings('token', token)

@classmethod
def get_auth_url(self):
def get_auth_url(cls):
"""
Return the auth url. Mandatory
"""

return self.base_url + self.auth_url
return cls.base_url + cls.auth_url


def _get_data(response_body):
Expand Down
1 change: 0 additions & 1 deletion pyds8k/auth/ds8k/v1/auth.py
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@


class Auth(AuthBase):

base_url = Base.base_url
Loading
Loading