Task/csi 3503 add verification scrips only#226
Draft
matancarmeli7 wants to merge 9 commits into
Draft
Conversation
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
matancarmeli7
requested review from
ArbelNathan,
annaparienti,
barakda,
oriyarde,
roysahar and
tyichye19
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
oriyarde
reviewed
Dec 1, 2021
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
oriyarde
reviewed
Dec 1, 2021
oriyarde
reviewed
Dec 1, 2021
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
ArbelNathan
reviewed
Dec 2, 2021
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
oriyarde
reviewed
Dec 20, 2021
oriyarde
reviewed
Dec 20, 2021
oriyarde
reviewed
Dec 20, 2021
|
|
||
| get_csv_files (){ | ||
| current_csi_version=$(get_current_csi_version) | ||
| ls deploy/olm-catalog/*/$current_csi_version/manifests/ibm-block-csi-operator.v$current_csi_version.clusterserviceversion.yaml |
Contributor
There was a problem hiding this comment.
I still see the wildcard.
what happens if there's only one bundle for the current csi version? I don't think the test should fail. it should test what it can, and allow separate additions
oriyarde
reviewed
Dec 20, 2021
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
oriyarde
reviewed
Dec 22, 2021
|
|
||
| verify_yaml_doc_in_multidoc_yaml(){ | ||
| yamls_dictionary=${1#*=} | ||
| eval "declare -A yaml_kinds_by_origin_yaml_path="${yamls_dictionary} |
Contributor
There was a problem hiding this comment.
https://stackoverflow.com/a/3467959
Avoid eval like the plague
Contributor
Author
There was a problem hiding this comment.
I tried without it and I didn't manage to find a solution, the variable pass between the functions interrupted it, you sent an example without a function
Contributor
There was a problem hiding this comment.
oriyarde
reviewed
Dec 22, 2021
Comment on lines
+48
to
+52
| [$roles_yaml_path]="ClusterRole" | ||
| [$crd_yaml_path]="CustomResourceDefinition" | ||
| ["config/rbac/service_account.yaml"]="ServiceAccount" | ||
| ["config/rbac/role_binding.yaml"]="ClusterRoleBinding" | ||
| ["config/manager/manager.yaml"]="Deployment" |
Contributor
There was a problem hiding this comment.
why do we need the kinds hardcoded? can't we find them dynamically?
Contributor
Author
There was a problem hiding this comment.
I will open a ticket
Contributor
There was a problem hiding this comment.
to add resource_type=$(yq e .kind $original_yaml)?
oriyarde
reviewed
Dec 22, 2021
|
|
||
| verify_no_crds_diff (){ | ||
| echo "check crds alignment" | ||
| are_manifest_files_exist_in_current_csi_version |
oriyarde
reviewed
Dec 22, 2021
Comment on lines
+35
to
+36
| ls deploy/olm-catalog/ibm-block-csi-operator-community/$current_csi_version/manifests/ibm-block-csi-operator.v$current_csi_version.clusterserviceversion.yaml | ||
| ls deploy/olm-catalog/ibm-block-csi-operator/$current_csi_version/manifests/ibm-block-csi-operator.clusterserviceversion.yaml |
Contributor
There was a problem hiding this comment.
consider moving the olm-catalog path to a common "const"
oriyarde
reviewed
Dec 22, 2021
Comment on lines
+23
to
+34
| check_generation (){ | ||
| echo "check generation" | ||
| project_dirname=ibm-block-csi-operator | ||
| cd .. | ||
| cp -r $project_dirname ./$project_dirname-expected | ||
| cd $project_dirname-expected/ | ||
| make update | ||
| cd .. | ||
| diff -qr --exclude=bin $project_dirname $project_dirname-expected/ | ||
| rm -rf $project_dirname-expected/ | ||
| cd $project_dirname | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| check_generation (){ | |
| echo "check generation" | |
| project_dirname=ibm-block-csi-operator | |
| cd .. | |
| cp -r $project_dirname ./$project_dirname-expected | |
| cd $project_dirname-expected/ | |
| make update | |
| cd .. | |
| diff -qr --exclude=bin $project_dirname $project_dirname-expected/ | |
| rm -rf $project_dirname-expected/ | |
| cd $project_dirname | |
| } | |
| check_generation ()( | |
| echo "check generation" | |
| project_path=$PWD | |
| cp -r $project_path $project_path-expected | |
| cd $project_path-expected | |
| make update | |
| diff -qr --exclude=bin $project_path $project_path-expected/ | |
| cd .. | |
| rm -rf $project_path-expected/ | |
| ) |
would this work? less cd (+ absolute paths are more accurate + no hardcoded project name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: matancarmeli7 matan.carmeli7@gmail.com