Skip to content

CSI-5277/ separate addon code from controller server#656

Open
matancarmeli7 wants to merge 6 commits into
developfrom
task/CSI-5277_separate_addons_code_from_controller_server
Open

CSI-5277/ separate addon code from controller server#656
matancarmeli7 wants to merge 6 commits into
developfrom
task/CSI-5277_separate_addons_code_from_controller_server

Conversation

@matancarmeli7

@matancarmeli7 matancarmeli7 commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7 matancarmeli7 requested review from a team, ArbelNathan and ELENAGER February 8, 2023 12:25
@matancarmeli7 matancarmeli7 changed the title separate addon code from controller server CSI-5277/ separate addon code from controller server Feb 8, 2023
Comment thread controllers/servers/csi/csi_addons_server/identity_controller_servicer.py Outdated
matancarmeli7 and others added 3 commits February 12, 2023 17:44
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>

@ArbelNathan ArbelNathan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ArbelNathan
ArbelNathan previously approved these changes Feb 22, 2023

@ArbelNathan ArbelNathan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants