fix: add failback for shef infile import when tsid doesn't exist#218
Merged
Conversation
Collaborator
Author
|
hang on....getting more in files to make this importer more robust |
Collaborator
Author
|
@Enovotny this is ready for review/merge. I forgot to follow up. Some of the issues we were having were group issues with empty timeseries. Should be good to go now |
Collaborator
|
@msweier did you see a new version of shef-parsers that went out yesterday that should fix the empty ts issue? |
Enovotny
approved these changes
Jun 4, 2026
Collaborator
Author
No i did not. We just got rid of the timeseries as a work around. Glad there is a fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cwmscli/commands/shef/import_infile.py
wasn't TSID-related).
cwmscli/commands/commands_cwms.py
tests/commands/test_shef_import_infile_dry_run.py
to fail outright, mocks get_timeseries_identifier to raise for one TSID. Asserts two store calls (3 then 2 members), the missing TSID is absent from the retry, and the expected
warnings are logged.