Skip to content

refactor(app): tighten nested project route validations#759

Merged
HugoRCD merged 1 commit into
mainfrom
refactor/team-project-context-followup
May 31, 2026
Merged

refactor(app): tighten nested project route validations#759
HugoRCD merged 1 commit into
mainfrom
refactor/team-project-context-followup

Conversation

@HugoRCD

@HugoRCD HugoRCD commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Validate bulk variable operations before writes
  • Scope group update/delete and variable group assignment to the route project

Test plan

  • pnpm test test/unit/team-project-context.test.ts test/unit/token-scopes.test.ts (apps/shelve)

@vercel

vercel Bot commented May 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
shelve-app Building Building Preview, Comment, Open in v0 May 31, 2026 7:17pm
shelve-lp Building Building Preview, Comment May 31, 2026 7:17pm
shelve-vault Building Building Preview, Comment May 31, 2026 7:17pm

@HugoRCD HugoRCD merged commit 4af0de2 into main May 31, 2026
10 of 15 checks passed
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@HugoRCD, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 96c6b843-d02f-4f3a-a257-2c408a7c2427

📥 Commits

Reviewing files that changed from the base of the PR and between f9cfe6e and a8feaf3.

📒 Files selected for processing (8)
  • .changeset/team-project-context.md
  • apps/shelve/server/api/teams/[slug]/projects/[projectId]/variable-groups/[groupId]/index.delete.ts
  • apps/shelve/server/api/teams/[slug]/projects/[projectId]/variable-groups/[groupId]/index.put.ts
  • apps/shelve/server/api/teams/[slug]/projects/[projectId]/variables/[variableId]/index.put.ts
  • apps/shelve/server/services/projects.ts
  • apps/shelve/server/services/variable-groups.ts
  • apps/shelve/server/services/variables.ts
  • apps/shelve/test/unit/team-project-context.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/team-project-context-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Improved code, clearer, simpler, etc...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant