ci: run @evlog/cli tests and publish it via pkg-pr-new#449
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow adds a dedicated CLI test job, requires it before publishing, and includes ChangesCLI CI and publishing
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packages/cli(@evlog/cli) has 15 test files / 84 tests, but nothing in.github/workflows/ran them:testjob only runsvitestinsidepackages/evlogpublish(pkg-pr-new) job only published./packages/evlog,./packages/nuxthub,./packages/telemetrySo the CLI had no CI test coverage and no PR preview install link.
Fix
clijob that runspnpm exec turbo run test --filter=@evlog/cli(same pattern as the existingtelemetryjob)clito thepublishjob'sneeds./packages/clito the pkg-pr-new publish commandNo changeset — internal CI config only, doesn't touch the published package.
Summary by CodeRabbit
Tests
New Features