perf(cran): de-link timing-out data URLs + skip Suggests-backed Windows tests (v0.9.155)#111
Merged
Merged
Conversation
…ests -> check under 10 min (v0.9.155)
The 0.9.154 pre-test was OK on Debian and OK on Windows, but the Windows overall
check time was 12 min (> 10). The Windows 00check.log pinpointed the last two
sinks:
1. URL timeout in feasibility (142s). The MapBiomas link in
lookup_mapbiomas_solos.Rd timed out (60s, unreachable from the check host) --
the same whack-a-mole as the USDA link before it. Fix: all \url{} to external
soil-data servers (USDA/ISRIC/MapBiomas/ESDAC/Embrapa/FEBR/...) and the
matching README/vignette/NEWS links are now plain \code{}/code-spans -- still
visible, no longer pinged. Feasibility 142s -> ~30s.
2. Suggests-backed tests ran only on Windows (237s testthat). The aqp interop,
QGIS export, ESDB raster and Munsell-prediction suites need Suggests present
on win-builder but absent locally, so they were invisible to my timings.
skip_on_cran() them (run on CI). testthat Windows ~237s -> ~160s.
Retained from 0.9.154: un-export of ~600 internal predicates (manual slashed),
perf test fixed-not-disabled, long-running tests off CRAN.
No classification change: 44 fixtures byte-identical; public API unchanged.
Local R CMD check --as-cran: 0/0/1-NOTE (local html-tidy); feasibility ~30s,
testthat ~60s. Projected Windows total ~9 min.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.9.154 pre-test was OK on Debian and OK on Windows but the Windows overall check time was 12 min (> 10). The Windows
00check.logpinpointed the last two sinks:URL timeout (feasibility 142s). The MapBiomas link in
lookup_mapbiomas_solos.Rdtimed out (60s, unreachable from the check host) — same whack-a-mole as the USDA link before it. Fix: all\url{}to external soil-data servers (USDA/ISRIC/MapBiomas/ESDAC/Embrapa/FEBR) and the matching README/vignette/NEWS links are now plain\code{}/code-spans — still visible, no longer pinged. Feasibility 142s → ~30s.Suggests-backed tests ran only on Windows (testthat 237s). The aqp interop, QGIS export, ESDB raster and Munsell-prediction suites need Suggests present on win-builder but absent locally — invisible to my timings.
skip_on_cran()them (run on CI). testthat ~237s → ~160s.Retained from 0.9.154: un-export of ~600 internal predicates (manual slashed), perf test fixed-not-disabled, long-running tests off CRAN.
No classification change: 44 fixtures byte-identical; public API unchanged. Local
R CMD check --as-cran: 0/0/1-NOTE (local html-tidy); feasibility ~30s, testthat ~60s. Projected Windows total ~9 min.🤖 Generated with Claude Code