Skip to content
This repository was archived by the owner on Oct 27, 2018. It is now read-only.

Adding Influx v0.9 line protocol support#17

Closed
mr337 wants to merge 2 commits into
HubSpot:masterfrom
mr337:dump_influxdb_json
Closed

Adding Influx v0.9 line protocol support#17
mr337 wants to merge 2 commits into
HubSpot:masterfrom
mr337:dump_influxdb_json

Conversation

@mr337

@mr337 mr337 commented Sep 16, 2015

Copy link
Copy Markdown

This PR adds line protocol support when using influxdb version 0.9 and use_json is true.

Backward compatibility is kept for JSON for 0.8 and 0.9. This PR doesn't support tagging for v0.9 via line protocol. I'd be interested to hear any ideas on how to support them since there are different tags for different sites/organizations.

@mr337 mr337 changed the title Adding in v0.9 line protocol support Adding Influx v0.9 line protocol support Sep 16, 2015
@JSMike

JSMike commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

See #18
It's more backwards compatible.

@mr337

mr337 commented Sep 29, 2015

Copy link
Copy Markdown
Author

Bleh, I'll take your word for it.

@mr337 mr337 closed this Sep 29, 2015
@JSMike

JSMike commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

I welcome criticism for my PR, sry if I came off harsh.
0.9 has deprecated json format, and it will be removed in 1.0, so I took it out as an option, 0.9 always sends as line protocol.
I also included necessary changes for sending retention policy.
Also, check out my changes to the client for influxDBLineProtocol https://github.com/JSMike/BuckyClient

@mr337

mr337 commented Sep 29, 2015

Copy link
Copy Markdown
Author

No not at all @JSMike, js and coffeescript are not my strong suit at all. In fact first time I have messed with coffeescript and influxdb. So been learning a lot recently!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants