Skip to content

Hotfix/circular fix #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oceanshiver wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Hotfix/circular fix #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/HubCloud.BlazorSheet.EvalEngine/Engine/DependencyAnalyzer/SheetDependencyAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,7 @@ public List<SheetCell> OrderCellsForCalc2()
return resultList;
}


#region private methods
private void CheckCircularCells(List<SheetCell> sheetCells)
public void CheckCircularCells(List<SheetCell> sheetCells)
{
var circularCells = new List<ValueAddress>();
foreach (var cell in sheetCells)
Expand All @@ -140,6 +138,8 @@ private void CheckCircularCells(List<SheetCell> sheetCells)
}
}

#region private methods

private string GetCircularCellsStr(List<SheetCell> badCells)
{
var resultStr = string.Empty;
Expand Down
2 changes: 2 additions & 0 deletions src/HubCloud.BlazorSheet.EvalEngine/Engine/WorkbookEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ private void EvalSheet(Sheet sheet, SheetData cells)
var formulaCells = sheet.Cells
.Where(x => IsFormula(x.Formula))
.ToList();

_analyzer.CheckCircularCells(formulaCells);

// formulas without depend
var endingFormulas = new List<ValueAddress>();
Expand Down