fix(mcp_server): handle missing team_id argument safely#285
Merged
Conversation
Dispatcher.call_tool raised an unhandled KeyError when an MCP client omitted team_id, crashing the stdio server. Raise a descriptive ValueError (MissingArgumentError) instead — mirroring UnknownToolError — which the SDK's call_tool wrapper converts into a structured isError result, so the server stays alive across bad requests. Closes #283 Implemented-By: claude-sonnet-4-6 Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
GHSA-4xgf-cpjx-pc3j) Signed-off-by: Micah Villmow <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add defensive guard for missing team_id argument in Dispatcher.call_tool to prevent unhandled KeyError from crashing the MCP server process. Raise a descriptive ValueError instead so the server remains responsive across malformed requests.
Changes
Testing
Closes
Closes #283
Generated by Claude Code via ProjectHephaestus automation.