fix(ci): deduplicate workflows by removing ci.yml#257
Open
mvillmow wants to merge 1 commit into
Open
Conversation
mvillmow
commented
Jun 20, 2026
mvillmow
left a comment
mvillmow
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — ci.yml (inferior duplicate) deleted, _required.yml superset retained, coverage flag preserved at _required.yml:185; no stale refs to deleted check names.
Delete .github/workflows/ci.yml (duplicate of _required.yml) and add coverage reporting flags to the surviving _required.yml unit-tests job to preserve coverage signal. Closes #151 Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates duplicate
lint,test, andsecrets-scanjobs that run twice on every push/PR by deleting.github/workflows/ci.ymland preserving the strict superset_required.yml.ci.ymljobs:lint-and-test,secrets-scan_required.ymljobs:lint,unit-tests,security/secrets-scan, plus 10 additional gatesci.ymlare redundant with jobs in_required.ymlChanges
.github/workflows/ci.yml— all jobs are duplicates of_required.yml_required.yml— append--cov=telemachy --cov-report=term-missingto pytest inunit-testsjob to preserve coverage signalVerification
✓ No duplicate jobs (enumerated via YAML parse)
✓ YAML syntax valid (yamllint + python parser)
✓ Coverage signal preserved (grep for flag)
✓ No stale references to deleted workflow
Note for Operators
If branch protection rules currently reference the now-deleted check names
Lint & Testorsecrets-scan(fromci.yml), they must be re-pointed to the surviving check names from_required.yml:lintunit-testssecurity/secrets-scan(No such rules are currently configured in this repo.)
Closes #151