Integration tests for workflow lifecycle#255
Merged
Merged
Conversation
mvillmow
force-pushed
the
146-auto-impl
branch
2 times, most recently
from
3d78e7a to
6c4d6c8
Compare
- Add tests/stub_agamemnon.py: in-process ASGI stub of ProjectAgamemnon REST API - Add tests/conftest.py: shared fixtures for integration tests - make_client_for(stub) sync helper for constructing stub-bound clients - client_pool async fixture for managing client lifetimes - stub_agamemnon_factory, make_spec, write_workflow_yaml fixtures - load_workflow() helper to quarantine cli._load_workflow import - Add tests/test_workflow_lifecycle.py: six integration tests covering: 1. Happy path: single agent, single task, teardown on_completion 2. Dependent tasks: task B blocked on task A with custom status sequences 3. Failed dependency: task A fails, task B is skipped, workflow fails 4. Partial provisioning failure: agent 2 fails, agent 1 is torn down 5. Docker runtime: verifies /v1/agents/docker endpoint is used 6. CLI load path: YAML round-trip through _load_workflow runs end-to-end - Register @pytest.mark.integration in pyproject.toml - Update justfile: just test (full), just test-unit (unit only), just test-integration (integration only) - Update CLAUDE.md: document test taxonomy and stub behavior Implements issue #146: full workflow lifecycle end-to-end against stubbed REST API. All 54 tests pass (48 unit + 6 integration). Marker filtering verified. Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
No follow-ups within scope. All lifecycle tests pass; conftest fixtures verified to not collide with existing tests; architectural decisions (hook scope, coverage gates) were deliberate, not discovered gaps. Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #146 by adding end-to-end integration tests that exercise the full Telemachy workflow lifecycle against an in-process ASGI stub of the Agamemnon REST API.
tests/stub_agamemnon.py: Complete ASGI stub implementing all Agamemnon endpoints used by Telemachytests/conftest.py: Shared fixtures includingmake_client_for()helper andclient_poollifetime fixturetests/test_workflow_lifecycle.py: Six lifecycle tests covering happy path, dependencies, failures, teardown policies, and CLI integrationpyproject.tomlto register the@pytest.mark.integrationmarkerjustfilewithtest-integrationandtest-unitrecipesCLAUDE.mdwith test taxonomy documentationTesting
All 54 tests pass (48 existing unit tests + 6 new integration tests):
pytestruns full suite (unit + integration)pytest -m integrationruns only the 6 lifecycle testspytest -m "not integration"runs only the 48 unit testsjust test,just test-integration, andjust test-unitall work as documentedCloses #146