Add coverage floor threshold (--cov-fail-under=75)#254
Open
mvillmow wants to merge 2 commits into
Open
Conversation
mvillmow
commented
Jun 20, 2026
mvillmow
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — cov-fail-under=75 configured in pyproject.toml + mirrored in ci.yml and the required _required.yml gate; source pin prevents flag-less false-pass. Correct, complete, well-scoped.
Configure a 75% code coverage floor in pyproject.toml [tool.coverage.report] with explicit CLI flags in both CI workflows to prevent silent coverage regressions. The floor is sourced from config and mirrored in ci.yml and _required.yml for visibility. Fixes #148 Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
GHSA-4xgf-cpjx-pc3j) Signed-off-by: Micah Villmow <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlto prevent silent coverage regressions--cov-fail-under=75flag in bothci.ymland_required.ymlfor visibilityCLAUDE.mddocumenting the floor and how to reproduce it locallyImplementation Details
The implementation follows the approved plan from issue #148:
pyproject.toml: Added[tool.coverage.run] source = ["telemachy"]and[tool.coverage.report] fail_under = 75ci.yml: Added--cov-fail-under=75to the pytest command (line 34)_required.yml: Added full coverage flags to theunit-testsjob (line 185) to ensure the required gate enforces the floorCLAUDE.md: Documented the floor and reproduction steps in Development GuidelinesVerification
Verified all acceptance criteria from the plan:
pixi run pytest ... --cov-fail-under=75exits 0 with "Required test coverage of 75% reached"pixi run pytest ... --cov=telemachy(without explicit flag) also enforces the floor viapyproject.tomlpyproject.tomlparses correctly withfail_under = 75ruff checkandyamllintpassCloses #148