Skip to content

feat(e2e): add import-linter infrastructure for e2e/ decomposition (#1940)#2008

Open
mvillmow wants to merge 1 commit into
mainfrom
1940-e2e-god-package
Open

feat(e2e): add import-linter infrastructure for e2e/ decomposition (#1940)#2008
mvillmow wants to merge 1 commit into
mainfrom
1940-e2e-god-package

Conversation

@mvillmow

Copy link
Copy Markdown
Collaborator

Summary

  • Installs import-linter >=2.0,<3 as a dev dependency in pixi.toml (resolves plan review finding F7 by including grimp transitively via import-linter)
  • Creates .importlinter with root_packages = scylla; no active bans yet — contracts tighten PR-by-PR as files move out of scylla.e2e (staged contract approach from §7 of plan)
  • Adds lint-imports task to pixi.toml (pixi run lint-imports)
  • Wires pixi run lint-imports into the unit-tests CI job in _required.yml
  • Regenerates pixi.lock after dependency addition (resolves plan review finding F8)
  • Adds 5 unit tests in tests/unit/e2e/test_import_linter_config.py guarding the config infrastructure

Divergences from plan noted

  • Plan §7 specified the baseline contract as "forbid e2e → cli" but progress.py still imports scylla.cli, so that ban cannot be active until progress.py is moved/deleted (future PR). Baseline starts with zero contracts — infrastructure only.
  • grimp is included transitively by import-linter; no separate entry needed.

Verification

pixi run lint-imports   # 0 contracts, 0 broken — passes
pixi run pytest tests/unit/e2e/test_import_linter_config.py  # 5/5 passed
pre-commit run --all-files  # all hooks passed

Closes #1940

🤖 Generated with Claude Code

@mvillmow mvillmow enabled auto-merge (squash) May 29, 2026 23:18
@mvillmow mvillmow force-pushed the 1940-e2e-god-package branch from 896c3db to 1f84974 Compare June 1, 2026 05:43
…1940)

Installs import-linter as a dev dependency, creates a .importlinter
config with root_packages=scylla, adds a lint-imports pixi task, and
wires it into the unit-tests CI job. No active bans yet — contracts
tighten PR-by-PR as files move out of scylla.e2e (issue #1940 PR-A).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
@mvillmow mvillmow force-pushed the 1940-e2e-god-package branch from 1f84974 to 711b87f Compare June 28, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Audit] §3 MAJOR: e2e/ is a god-package (52–56 files, hub of dependency graph)

1 participant