Skip to content

fix(audit): update remediation-plan checkbox states for closed issues#195

Open
mvillmow wants to merge 1 commit into
mainfrom
186-auto-impl
Open

fix(audit): update remediation-plan checkbox states for closed issues#195
mvillmow wants to merge 1 commit into
mainfrom
186-auto-impl

Conversation

@mvillmow

Copy link
Copy Markdown
Contributor

Summary

Corrects stale checkbox states in the audit remediation plan for 10+ already-closed issues. Marks completed items as [x], adds missing #85 entry to Wave 1, and introduces a regression test to prevent future checkbox drift.

Changes

Testing

  • Verify all closed issues (per GitHub API) are marked [x] in remediation-plan.md
  • Confirm regression test passes: ./tests/remediation-plan-checkboxes.test.sh
  • Confirm CI job runs and passes on push

Closes

Closes #186

Generated by Claude Code via ProjectHephaestus automation.

Wave 1, 2, and 3 in remediation-plan.md contained stale checkbox states for 10+ issues already closed before this PR. Mark all closed issues with [x] and add missing #85 (critical, pre-closed) to Wave 1 to prevent agents from picking up resolved work. Add regression test to catch future checkbox drift.

Closes #186

Implemented-By: claude-sonnet-4-6
Co-Authored-By: Claude Code <noreply@anthropic.com>

@mvillmow mvillmow left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc correction + offline test are correct and complete, but err.txt (a transient dispatch-apply test artifact) was committed to repo root — unrelated to #186, must be removed.

Comment thread err.txt
@@ -0,0 +1 @@
Error: host is required (pass as $1 or set HOST env var). See docs/dispatch-contract.md (#84).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a transient artifact, not an intended deliverable. It is written by tests/dispatch-apply.test.sh:37 (2>err.txt) to the current working directory and was accidentally git added in this PR. It is unrelated to issue #186 and pollutes the repo root. Remove it from the commit (git rm err.txt), add err.txt to .gitignore, and ideally redirect the source test to a mktemp path so the artifact can never be committed again.


# --- Committed fixture: the checkbox state each line MUST have. ---
# Per-issue lines (Wave 1 & 2): key=issue number, value=x (CLOSED) or " " (OPEN).
declare -A EXPECTED=(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EXPECTED fixture and the Wave-3 group # CLOSED/OPEN comments are a point-in-time snapshot of GitHub state. If any tracked issue is later reopened, this test will silently keep passing against a now-stale doc until someone manually re-runs the RE-VERIFY command — the guard cannot detect that drift. The RE-VERIFY note documents the refresh procedure but nothing enforces it. Acceptable given the offline-hermetic tradeoff, but worth noting the guard protects against doc-vs-fixture drift, not fixture-vs-GitHub drift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-up from #81: 1 item(s) (core)

1 participant