fix(#94): align required status checks ruleset with _required.yml jobs#166
Open
mvillmow wants to merge 2 commits into
Open
fix(#94): align required status checks ruleset with _required.yml jobs#166mvillmow wants to merge 2 commits into
mvillmow wants to merge 2 commits into
Conversation
Add 5 missing required status checks to the homeric-main-baseline ruleset (forbid-suppressions, markdownlint, pixi-check, justfile-check, symlink-check) and consolidate TypeScript type-checking into the lint job instead of a separate typecheck job. This addresses the issue where PRs could merge despite breaking TypeScript types, security scans, markdownlint, pixi-check, or justfile validation. Changes: - Fold TypeScript (tsc --noEmit) into _required.yml/lint as a step - Move verify-issue-92-invariants.sh regression guard into lint job - Add 5 missing contexts to the branch protection ruleset - Create regression test (test-required-checks-ruleset.sh) to prevent drift - Delete ci.yml (now-redundant jobs merged into _required.yml) - Update docs/branch-protection.md with complete list of 13 required contexts - Create auxiliary JSON files for classic branch protection update - Update dagger/src/index.ts to fix #92 invariants (npm cache, scoping, JSON output) Closes #94 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
Analysis of issue #94 implementation identified no in-scope follow-ups. Rejected items (regression test robustness, remediation-plan update) are either non-critical or addressed by guard conditions / non-existent files. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the
homeric-main-baselinerepository ruleset's required-status-checks with the actual job inventory in.github/workflows/_required.yml. This fixes the audit finding that PRs could merge despite breaking TypeScript types, security scans, markdownlint, pixi-check, or justfile validation.Changes
tsc --noEmitinto_required.yml/lintjob instead of separateci.yml/typecheckjobverify-issue-92-invariants.shinto lint job for [MAJOR] §4: lint() runs npm ci in container on every call — non-cacheable and self-referential #92 fix validationtests/test-required-checks-ruleset.shprevents future drift between ruleset and workflow jobs_required.ymldagger/src/index.tsto implement npm cache volume, directory scoping, and structured JSON outputTest plan
Closes #94
Co-Authored-By: Claude Haiku 4.5 noreply@anthropic.com