test: replace teardown_method with fixture for auth cleanup#691
Open
mvillmow wants to merge 2 commits into
Open
test: replace teardown_method with fixture for auth cleanup#691mvillmow wants to merge 2 commits into
mvillmow wants to merge 2 commits into
Conversation
mvillmow
commented
Jun 21, 2026
mvillmow
left a comment
mvillmow
left a comment
Contributor
Author
There was a problem hiding this comment.
Test-fixture fix is correct and complete, but PR commits coverage.xml (855-line build artifact leaking a local absolute path); remove and gitignore before merge.
Use a pytest fixture with yield to ensure dead_letter_api_key is reset even if tests raise before teardown_method executes. Avoids singleton pollution and test interdependencies. Closes #521 Implemented-By: claude-sonnet-4-6 Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com>
Generated coverage report should not be in version control (churns on every test run, leaks absolute local paths). Addresses review feedback. Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use pytest fixtures with yield to ensure dead_letter_api_key is reset even if tests raise before teardown_method executes. Prevents singleton pollution and test interdependencies when assertions fail mid-setup.
Changes
Testing
Closes
Closes #521
Generated by Claude Code via ProjectHephaestus automation.