refactor(test): exercise real shutdown loop in lifespan tests#668
Open
mvillmow wants to merge 6 commits into
Open
refactor(test): exercise real shutdown loop in lifespan tests#668mvillmow wants to merge 6 commits into
mvillmow wants to merge 6 commits into
Conversation
mvillmow
commented
Jun 20, 2026
mvillmow
left a comment
mvillmow
left a comment
Contributor
Author
There was a problem hiding this comment.
Tests now drive the real lifespan drain loop via async with lifespan(app); correct & complete. Two minor nits: deprecated get_event_loop() and a flake-prone wall-clock upper bound.
mvillmow
force-pushed
the
460-auto-impl
branch
2 times, most recently
from
959d72f to
f7449cb
Compare
…hutdown Both test_shutdown_waits_for_inflight_requests and test_shutdown_proceeds_after_timeout now drive the actual lifespan context manager via 'async with lifespan(app)' instead of duplicating the polling loop from server.py. This ensures regression mutations to the shutdown logic (e.g., wrong condition, missing disconnect) are caught by the tests. Changes: - Add 'patch' to top-level mock imports - Extend _make_mock_publisher() to set 'connect' as AsyncMock so lifespan's _connect_with_retries call chain doesn't TypeError - Refactor both tests to use 'async with lifespan(app)' with patched Publisher - Clear get_settings cache before and after tests to ensure SHUTDOWN_TIMEOUT env is observed - Use try/finally to reset _inflight and _shutdown_event regardless of assertion outcome Tests now verify that disconnect is called at the exact moment _inflight reaches 0 (waits test) and that timeout deadlines are honored (timeout test). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
Reviewed implementation for follow-ups per strict scope rules. No defects, security issues, safety hazards, or critical bugs were introduced by the refactoring. Two items (Python version compatibility and deprecation warnings) were pre-existing and out of scope. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
…ertion Replace deprecated asyncio.get_event_loop() with asyncio.get_running_loop() in test_shutdown_proceeds_after_timeout — required for Python 3.10+ coroutines. Drop the flaky wall-clock upper bound (elapsed < timeout + 1.5); the lower bound (elapsed >= timeout) is the real regression guard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
Return properly formatted JSON follow-up response per template. No follow-ups file as all pre-existing issues were addressed in the implementation plan review. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
This internal follow-up note was committed by the automation loop but is unrelated to issue #460 and tripped the end-of-file-fixer pre-commit hook (missing trailing newline). Remove it and gitignore the .claude-followup-*.md pattern so it cannot recur. Addresses lint failure. Signed-off-by: Claude Haiku 4.5 <4211002+mvillmow@users.noreply.github.com> Signed-off-by: mvillmow <4211002+mvillmow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestLifespanShutdown.test_shutdown_waits_for_inflight_requestsandtest_shutdown_proceeds_after_timeoutto exercise the real shutdown polling loop viaasync with lifespan(app)instead of duplicating it_make_mock_publisher()to setconnectasAsyncMockso the lifespan entry path doesn't TypeErrorTest plan
await publisher.disconnect()) causes both tests to failtest_shutdown.pypass (no regressions in TestShutdownMiddleware or TestInflightCounter which share_make_mock_publisher)Closes #460