Skip to content

Gemfile: Unconstrain the tapioca version#22095

Merged
issyl0 merged 5 commits into
mainfrom
unconstrain-tapioca
Apr 27, 2026
Merged

Gemfile: Unconstrain the tapioca version#22095
issyl0 merged 5 commits into
mainfrom
unconstrain-tapioca

Conversation

@issyl0

@issyl0 issyl0 commented Apr 26, 2026

Copy link
Copy Markdown
Member

Fixes #22098


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

  • We're using a version of Tapioca == 0.19.0 these days after commit 1078f43, so the comment no longer applies, so the version constraint can be removed.
  • Ran brew vendor-gems; brew tc --update and force-pushed the results.

Copilot AI review requested due to automatic review settings April 26, 2026 12:55
@issyl0 issyl0 enabled auto-merge April 26, 2026 12:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-outdated upper bound on the optional tapioca gem used for typechecking tooling, aligning the Gemfile with current usage and eliminating an obsolete TODO.

Changes:

  • Drop the < 0.20.0 constraint for tapioca in the :typecheck gem group.
  • Update Gemfile.lock dependency entry to reflect the unconstrained requirement while retaining the locked resolved version.
Show a summary per file
File Description
Library/Homebrew/Gemfile Removes the outdated TODO and the tapioca upper-bound constraint in the :typecheck group.
Library/Homebrew/Gemfile.lock Updates the dependency list entry for tapioca to match the Gemfile change.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/2 changed files
  • Comments generated: 0

@issyl0 issyl0 force-pushed the unconstrain-tapioca branch from 2d8b804 to 0677562 Compare April 26, 2026 13:22
- We're using a version of Tapioca == 0.19.0 these days after
  commit 1078f43, so the comment no
  longer applies, so the version constraint can be removed.
@issyl0 issyl0 force-pushed the unconstrain-tapioca branch from 0677562 to a99277b Compare April 26, 2026 13:24

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR wasn't released yet: Shopify/rubydex#725

@issyl0

issyl0 commented Apr 26, 2026

Copy link
Copy Markdown
Member Author

Seems this PR wasn't released yet: Shopify/rubydex#725

The commit is included in release v0.1.0.beta12 which is in our Gemfile.

@MikeMcQuaid

Copy link
Copy Markdown
Member

Apologies, ✅.

I've also taken this PR as a chance to update Tapioca and fix #22098

@MikeMcQuaid

Copy link
Copy Markdown
Member

Weird brew typecheck errors here 🤔

@issyl0

issyl0 commented Apr 27, 2026

Copy link
Copy Markdown
Member Author

Thanks @ZhongRuoyu!

@ZhongRuoyu ZhongRuoyu force-pushed the unconstrain-tapioca branch from 923b0e7 to 30f26bf Compare April 27, 2026 13:20
@ZhongRuoyu ZhongRuoyu requested a review from Bo98 April 27, 2026 13:22
@issyl0 issyl0 added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit f9f0eb4 Apr 27, 2026
38 checks passed
@issyl0 issyl0 deleted the unconstrain-tapioca branch April 27, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rubydex 0.1.0.beta12 fails to build on Intel Mac — missing Cargo precompiled binary

7 participants