discovery catalog import#7
Conversation
… and evaluation framework for TaarYa system
…tive research dashboard
…face components, and update project metadata and documentation.
…lude new research documentation and assets
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29889716 | Triggered | Generic Password | 4a185bb | deploy/helm/taarya/values.yaml | View secret |
| 29889716 | Triggered | Generic Password | 4a185bb | docker-compose.yml | View secret |
| 29889716 | Triggered | Generic Password | 4a185bb | docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9fbea0002
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| radius_deg=radius_deg, | ||
| star_count=inserted, | ||
| ingested_at=datetime.utcnow(), | ||
| ingested_at=datetime.datetime.now(datetime.timezone.utc), |
There was a problem hiding this comment.
This line will always raise AttributeError because the function imports datetime as a class (from datetime import datetime) and then calls datetime.datetime.now(...). In request_region_ingestion, that exception is caught and returned as an error string, so region ingestion cannot complete and the transaction is rolled back whenever this path runs.
Useful? React with 👍 / 👎.
| radius_deg = Column(Float, nullable=False) | ||
| star_count = Column(Integer, default=0) | ||
| ingested_at = Column(DateTime, default=datetime.utcnow) | ||
| ingested_at = Column(DateTime, default=lambda: datetime.datetime.now(datetime.timezone.utc)) |
There was a problem hiding this comment.
The new default callable uses datetime.datetime.now(...) even though this module imports datetime via from datetime import datetime, so inserts that rely on the column default will fail at runtime with AttributeError. Any code path creating a Region without explicitly setting ingested_at will hit this and fail to persist the row.
Useful? React with 👍 / 👎.
1 participant
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist