Backport ieee80211_is_first_frag() fix from upstream#21
Merged
Conversation
ieee80211_is_first_frag() operates on the seq_ctrl not the frame_control
header field. Pass the correct one in; otherwise the results may vary.
Sponsored by: The FreeBSD Foundation
Fixes: 30ce7f4456ae4 ("mt76: validate rx CCMP PN")
Link: https://cgit.freebsd.org/src/commit/sys/contrib/dev/mediatek/mt76/mac80211.c?id=c67fd35e58c6ee1e19877a7fe5998885683abedc
Signed-off-by: Bjoern A. Zeeb <bz@FreeBSD.org>
Link: https://patch.msgid.link/83s4psnr-popo-8789-757o-npr2n9n7rs2o@SerrOFQ.bet
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Copilot created this pull request from a session on behalf of
HiGarfield
June 10, 2026 15:31
View session
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backports an upstream mac80211 interoperability fix into this mt76 codebase by correcting the argument passed to ieee80211_is_first_frag() during CCMP PN validation, preventing fragment-handling misclassification.
Changes:
- Fixes CCMP PN fragment validation by passing
hdr->seq_ctrl(sequence control) toieee80211_is_first_frag()instead ofhdr->frame_control.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports necessary fixes from upstream openwrt/mt76 (latest 20 commits analyzed).
Changes
Applied 1 fix:
03644ac1: Fix argument toieee80211_is_first_frag()in CCMP PN validationThe function expects
seq_ctrlbut was incorrectly passedframe_control, causing potential validation errors:19 commits not applicable:
mt76_register_debugfs_fopschanges (this repo usesmt76_register_debugfs)All commits retain original authorship and commit messages from upstream.