-
Notifications
You must be signed in to change notification settings - Fork 3
ci: add missing check target to CI build loops
#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6c4de92
2fb8a04
d636bfa
cb1ceeb
2875d05
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -160,6 +160,7 @@ jobs: | |
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -B build | ||
| cmake --build build | ||
| cmake --build build --target check | ||
|
|
||
| done | ||
| rm -rf build | ||
|
|
||
|
|
@@ -234,6 +235,7 @@ jobs: | |
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -B build | ||
| cmake --build build | ||
| cmake --build build --target check | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The FreeBSD job now invokes the Useful? React with 👍 / 👎. |
||
| done | ||
| rm -rf build | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Linux/macOS matrix this new target now requires the
checktoolchain, but the job only installsgcc-multilib/libc6-dev-i386for Ubuntu and has no macOS install step forcppcheckorclang-tidy;cmake/RunCheck.cmakeexits fatally when either executable is missing. The current hosted macOS images do not list these tools, and Ubuntu does not listcppcheck, so these matrix entries can fail before reaching the tests unless the workflow installs/pins the analyzers before this line.Useful? React with 👍 / 👎.