Skip to content

Fix empty stdout#48

Open
cabloo wants to merge 1 commit into
Herzult:masterfrom
cabloo:patch-2
Open

Fix empty stdout#48
cabloo wants to merge 1 commit into
Herzult:masterfrom
cabloo:patch-2

Conversation

@cabloo

@cabloo cabloo commented Jul 14, 2015

Copy link
Copy Markdown

No description provided.

@dmouse

dmouse commented Sep 6, 2015

Copy link
Copy Markdown

👍

@cabloo

cabloo commented Sep 6, 2015

Copy link
Copy Markdown
Author

Would be nice to have this merged, the issue caused significant debugging pains for me a while back. I'm sure others have come across the same problem.

@h4cc

h4cc commented Sep 21, 2015

Copy link
Copy Markdown
Collaborator

The fix assumes, that if a command was executed and the echo part was not run, that result of the execution should be a error with a exit code != 0?

@Herzult Sounds right to me.

@cabloo

cabloo commented Mar 29, 2016

Copy link
Copy Markdown
Author

Bump. I just ran into this issue again when using this library in another project. I don't know what it is about these use cases but this has happened to me more than once now! And this is a pretty straightforward fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants