Fix ranlib when libdir is set. - #1267
Merged
Merged
Conversation
tobil4sk
reviewed
Nov 5, 2025
| { | ||
| args = [out_name]; | ||
| args = [mLibDir!=""?mLibDir+"/"+file_name:out_name]; | ||
| var result = ProcessManager.runCommand("", mRanLib, args, true, true, false, "\x1b[1mRanlib:\x1b[0m " + out_name); |
Member
There was a problem hiding this comment.
I guess it would also make sense to change out_name here for consistency, same for line 295
tobil4sk
reviewed
Nov 5, 2025
| { | ||
| sys.io.File.copy( mLibDir+"/"+file_name, out_name ); | ||
| FileSystem.deleteFile( mLibDir+"/"+file_name ); | ||
| Log.info("\x1b[1mMove file: \x1b[0m" + mLibDir+"/"+file_name + " to " + out_name); |
Member
There was a problem hiding this comment.
I think it's better to print before doing the action, that way if the action fails and crashes then we can see what stage the build was at before failing. This is also what ProcessManager.runCommand does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.