[display] Fix missing field mismatch error after display requests#12996
Open
yuxiaomao wants to merge 2 commits into
Open
[display] Fix missing field mismatch error after display requests#12996yuxiaomao wants to merge 2 commits into
yuxiaomao wants to merge 2 commits into
Conversation
…tics Typing in diagnostics mode turns errors like missing fields into diagnostics-only messages, which are filtered out when replayed outside of diagnostics mode. Reusing such a module in a compilation therefore silently dropped the error. Mark those modules dirty for non-diagnostics requests so they get typed again. Closes HaxeFoundation#12995
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try the fix that I found for (not closing because we need tests)
Simon said: