Store main thread in Jvm.init() - #12991
Open
kevinresol wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I actually tried to follow up by implementing the suggested alternative above. But that won't really fly because the Line 313 in 5f83789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: this actually does not fix my event loop problem. We actually need to probe the
haxe.EventLoopclass in the main function in order to capture the correct "main eventloop" into the TLS....I made a temp patch lib here: https://github.com/kevinresol/haxe12985/blob/main/src/haxe/issue12985/Patch.hx
A quick fix that is probably not ideal as it still brings in 3 extra classes (w/ full dce) into the output jar for a minimaltrace()Haxe app. But they are quite minimal (see below) and I think we should have it.A more proper fix is probably to store only the native java thread ref, and updatesys.thread.Threadto use it.See #12985