Skip to content

StringTools fastCodeAt make the default case fall back to using String charCodeAt #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PXshadow wants to merge 2 commits into
base: development
Choose a base branch
from
+5 −1
Open

StringTools fastCodeAt make the default case fall back to using String charCodeAt #12988

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7220d6a
StringTools fastCodeAt make the default case fall back to using Strin…
PXshadow Jul 15, 2026
2b304bc
StringTools add eval and php fast case using .cca fieldAccess
PXshadow Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion std/StringTools.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,14 +463,18 @@ class StringTools {
return if (index >= s.length) -1 else python.internal.UBuiltins.ord(python.Syntax.arrayAccess(s, index));
#elseif hl
return @:privateAccess s.bytes.getUI16(index << 1);
#elseif eval
return untyped s.cca(index);
#elseif php
return untyped s.cca(index);
#elseif lua
#if lua_vanilla
return lua.NativeStringTools.byte(s, index + 1);
#else
return lua.lib.luautf8.Utf8.byte(s, index + 1);
#end
#else
return untyped s.cca(index);
return s.charCodeAt(index);
#end
}

Expand Down
Loading