Skip to content

Fixing logic typos - #12941

Open
RblSb wants to merge 1 commit into
HaxeFoundation:developmentfrom
RblSb:minor-fixes
Open

Fixing logic typos#12941
RblSb wants to merge 1 commit into
HaxeFoundation:developmentfrom
RblSb:minor-fixes

Conversation

@RblSb

@RblSb RblSb commented Jun 10, 2026

Copy link
Copy Markdown
Member

Scanned codebase for simple typos:

  • m != m dead check (maybe intended to check something else, double check)
  • incorrect sl = [] || (List.mem name sl && is_new_item acc name) condition
  • Show ExprOf<String> as String instead of Expr in display for return types, same as for arguments implemented above: let a = if t1 == t_dynamic then a1' else a1
  • String.sub file dot_pos (String.length name - dot_pos) didn't remove "." from second extension, so Foo doesn't showing up in completion with Foo.test.hx right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant