Skip to content

Rebuild missing Cell Annotation manifests from on-disk checkpoint artifacts#69

Merged
yulewu merged 2 commits into
cell_annotationfrom
copilot/update-issue-15-tasks
Mar 17, 2026
Merged

Rebuild missing Cell Annotation manifests from on-disk checkpoint artifacts#69
yulewu merged 2 commits into
cell_annotationfrom
copilot/update-issue-15-tasks

Conversation

Copilot AI commented Mar 17, 2026

Copy link
Copy Markdown

This follow-up continues the Cell Annotation workflow scaffolding from the previous PR by replacing the placeholder manifest rebuild path. Dataset stores with checkpoint artifacts but no manifest.json can now recover their manifest state directly from disk.

  • Manifest rebuild

    • Replaced the stubbed Manifest.rebuild_from_disk() implementation with a filesystem scan of:
      • checkpoints/*.json
      • matching thumbnails/*
      • matching selections/*
    • Ignores partial artifacts during rebuild.
    • Normalizes each entry to include a stable id and an artifacts map with repository-relative paths.
  • Startup recovery

    • Updated CellAnnotationPlugin.on_dataset_opened() to rebuild the manifest automatically when the dataset store exists but manifest.json is missing.
    • Preserves the existing load path when a persisted manifest is already present.
  • Focused coverage

    • Replaced the old stub-oriented manifest test with coverage for:
      • checkpoint/thumbnails/selections discovery
      • partial-file exclusion
      • atomic persistence of rebuilt manifest data
      • plugin startup recovery when only checkpoint metadata exists

Example rebuilt entry shape:

{
    "id": "abc123",
    "parents": ["root"],
    "op": "save",
    "artifacts": {
        "checkpoint": "checkpoints/abc123.json",
        "thumbnail": "thumbnails/abc123.png",
        "selection": "selections/abc123.parquet",
    },
}

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: yulewu <38241047+yulewu@users.noreply.github.com>
Copilot AI changed the title [WIP] [#15] Follow up on pull request #68 Rebuild missing Cell Annotation manifests from on-disk checkpoint artifacts Mar 17, 2026
Copilot AI requested a review from yulewu March 17, 2026 23:21
@yulewu yulewu marked this pull request as ready for review March 17, 2026 23:26
@yulewu yulewu merged commit 74eb5cd into cell_annotation Mar 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants