refactor(config): alphabetize the instance Config nav items#1470
Open
dawsontoth wants to merge 1 commit into
Open
refactor(config): alphabetize the instance Config nav items#1470dawsontoth wants to merge 1 commit into
dawsontoth wants to merge 1 commit into
Conversation
Overview stays pinned at the top (and keeps its divider); the remaining items — Certificates, Deployments, Domains, Roles, Secrets, SSH Keys, Users — are now ordered alphabetically instead of by when each was added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes the navigation links in the configuration index page to be in alphabetical order, including Certificates, Deployments, Roles, Secrets, SSH Keys, and Users. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reorders the instance Config page nav so the items read alphabetically. Overview stays pinned at the top and keeps its divider (
border-t) from the rest — only the items below the divider move.Before → after:
(“Secrets” is the entry #1402 adds; it slots in alphabetically here so the two PRs don't fight over ordering.)
Only the JSX order in
src/features/instance/config/index.tsxchanged. Every item keeps its icon and its existing version/permission gate (certsAvailable,deploymentsAvailable,secretsSupported, self-managed/local checks) — nothing was added or removed, just resequenced. Icon imports were already alphabetized on the base branch, so no import change.Verification
tsc,oxlint,dprintall clean via the pre-commit hooks.🤖 Generated with Claude Code