Skip to content

fix(databases): reset to page 1 when the table filter changes #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dawsontoth wants to merge 1 commit into
base: stage
Choose a base branch
from
Open

fix(databases): reset to page 1 when the table filter changes #1465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/features/instance/databases/components/DatabaseTableView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,10 @@ export function DatabaseTableView({ instanceDatabaseMap, databaseName, tableName
allParams,
);

const [pageIndex, setPageIndex] = useEffectedState(0, [databaseName, tableName]);
// Reset to the first page when the table changes OR the applied filter changes. Without the
// filter dependency a stale page (e.g. page 3 -> offset 40) would be sent with the new filter,
// and a filter that matches fewer rows than that offset comes back empty (#1463).
const [pageIndex, setPageIndex] = useEffectedState(0, [databaseName, tableName, appliedSearchConditions]);
const [pageSize, setPageSize] = useState(20);

// The count comes from whichever describe carries it: the map when the server still returns counts
Expand Down