cherry-pick: Fix deploy silently truncating tarball on dangling symlink (#1718)#1732
Merged
Conversation
Fix deploy silently truncating tarball on dangling symlink
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where dangling symlinks silently truncate the deploy tarball during packaging. It introduces a pre-walk of the directory via scanPackageDirectory to identify dangling symlinks and estimate the package size in a single pass. These dangling symlinks are then ignored during the actual packaging process in streamPackagedDirectory to prevent tar-fs from terminating early, and a warning is printed to the user. Additionally, comprehensive unit tests have been added to cover these scenarios. There are no review comments to address, so no further feedback is provided.
Contributor
|
Reviewed; no blockers found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual redo of the automated cherry-pick (#1722), which left unresolved conflict markers in
DESIGN.mdfrom a stale branch point.The conflict was between #1718's own new "dangling symlink" DESIGN.md section and an unrelated, unlabeled
set_configurationreplication doc section (from #1556, not patch-labeled) that had been absorbed into #1718's branch via a stalemerge main— dropped that section, kept only #1718's genuine content.Verified:
unitTests/components/packageComponent.test.js+unitTests/bin/cliOperations.test.js— 12/12 passing.Closes the stalled #1722.