Skip to content

fix(test): await startCrlServer so the EADDRINUSE retry covers the listen #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kriszyp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(test): await startCrlServer so the EADDRINUSE retry covers the listen #1710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209d648
fix(test): await startCrlServer so EADDRINUSE retry covers the listen
Jul 8, 2026
5342369
Merge branch 'main' into kris/crl-server-retry-await
kriszyp Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion integrationTests/utils/securityServices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export async function setupCrlServerWithCerts(
try {
const { generateCrlCertificates } = await import('./security/crl/generate-test-certs.ts');
const certs = await generateCrlCertificates(certsPath, hostname, port);
return startCrlServer(certsPath, port, certs);
// await so EADDRINUSE from server.listen() lands in the catch and triggers retry
// (matches setupOcspResponderWithCerts pattern)
return await startCrlServer(certsPath, port, certs);
} catch (error: any) {
if (error.code === 'EADDRINUSE' && attempt < maxRetries - 1) {
continue;
Expand Down
Loading