-
Notifications
You must be signed in to change notification settings - Fork 8
ci: run Next.js adapter integration suite against harper PRs (downstream gate) #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kriszyp
wants to merge
1
commit into
main
Choose a base branch
from
kris/nextjs-caller-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Next.js Integration Tests (downstream) | ||
|
|
||
| # Runs the @harperfast/nextjs adapter's Playwright integration suite against THIS | ||
| # PR's harper build, so a harper change that breaks the Next.js framework-hosting | ||
| # integration (HTTP server, REST, ISR/`use cache` backed by Harper tables) is | ||
| # caught here rather than in the downstream adapter repo. | ||
| # | ||
| # It calls the reusable workflow in HarperFast/nextjs, passing this PR's head SHA | ||
| # as `harper_ref`; the reusable workflow checks out + builds harper at that ref and | ||
| # resolves it as the `harper` the test harness and fixtures run against. | ||
| # | ||
| # Scoped to PRs that touch the HTTP / cache / resource / server code paths the | ||
| # adapter exercises (tune the paths filter as coverage evolves). | ||
| # | ||
| # ── BEFORE MERGE ─────────────────────────────────────────────────────────────── | ||
| # 1. Depends on HarperFast/nextjs#49 — the `workflow_call` + `harper_ref` input | ||
| # must be on nextjs `main` first, or this caller has nothing to call. | ||
| # 2. Replace the mutable `@main` ref below with the 40-char merge-commit SHA of | ||
| # nextjs#49 (cross-repo reusable `uses:` should pin to a SHA, matching the | ||
| # convention in validate-caller-workflows.yml). | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'cache/**' | ||
| - 'resources/**' | ||
| - 'server/**' | ||
| - 'dataLayer/**' | ||
| - 'components/**' | ||
| - 'config/**' | ||
| - 'package.json' | ||
| - 'package-lock.json' | ||
|
|
||
| jobs: | ||
| nextjs-integration: | ||
| name: Next.js adapter integration (against this PR's harper) | ||
| uses: HarperFast/nextjs/.github/workflows/integration-tests.yml@main # TODO: pin to nextjs#49 merge SHA before merging | ||
| with: | ||
| harper_ref: ${{ github.event.pull_request.head.sha }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocker — mutable
@mainref not caught by the repo's validator.validate-caller-workflows.ymlonly coversclaude-*.ymlfiles, so this workflow bypasses the SHA-pinning check entirely. The@mainref means any push toHarperFast/nextjsmain can silently change what CI code runs against harper PRs — an unguarded supply-chain injection vector.The PR body already tracks this as a pre-merge TODO ("replace the mutable
@mainref below with the 40-char merge-commit SHA of nextjs#49"). Do that before lifting the draft — this should not land with@main.