Update defaultConfig.yaml comment to Harper branding and v5 docs link#492
Draft
DavidCockerill wants to merge 2 commits into
Draft
Update defaultConfig.yaml comment to Harper branding and v5 docs link#492DavidCockerill wants to merge 2 commits into
DavidCockerill wants to merge 2 commits into
Conversation
Rename "HarperDB" to "Harper" in the top comment of the default config and point the link at the current docs page (https://docs.harperdb.io/reference/v5/configuration/options); the old harperdb.io/docs/reference/configuration-file/ path is stale. Mirrors the equivalent change in harper core (HarperFast/harper#1494). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation URL and product name reference in the Harper configuration file (static/defaultConfig.yaml). I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Contributor
|
Reviewed; no blockers found. |
Use https://docs.harperdb.io/docs/deployments/configuration to match the comment in harper core (the v5 reference path was reverted there). The HarperDB -> Harper wording change stands. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dawsontoth
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the comment at the top of
static/defaultConfig.yaml:Two changes in one line:
HarperDB→Harperwording, and the staleharperdb.io/docs/reference/configuration-file/link replaced withdocs.harperdb.io/docs/deployments/configurationto match the comment already present in harper core (static/defaultConfig.yaml).Purpose
Brings harper-pro's root default-config comment in line with harper core's branding and doc link. (The harper-core counterpart PR was closed — core already carries this exact line.)
Notes
core/static/defaultConfig.yamlalready matches; this is the repo's own root config file.Generated by an LLM (Claude Opus 4.8).