Skip to content

feat: deploy faucet#668

Merged
GabrielMartinezRodriguez merged 9 commits into
masterfrom
gabriel/deploy-faucet
May 5, 2025
Merged

feat: deploy faucet#668
GabrielMartinezRodriguez merged 9 commits into
masterfrom
gabriel/deploy-faucet

Conversation

@GabrielMartinezRodriguez

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Description

This PR adds the GitHub Action required to deploy the faucet service

  • Include all relevant context (but no need to repeat the issue's content).
  • Draw attention to new, noteworthy & unintuitive elements.
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently packages/core and packages/react), see here for more info.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Apr 23, 2025

Copy link
Copy Markdown

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: fcb5086
Status: ✅  Deploy successful!
Preview URL: https://4de32742.happychain.pages.dev
Branch Preview URL: https://gabriel-deploy-faucet.happychain.pages.dev

View logs

GabrielMartinezRodriguez commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

@GabrielMartinezRodriguez GabrielMartinezRodriguez marked this pull request as ready for review April 23, 2025 13:18
@GabrielMartinezRodriguez GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label Apr 23, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/deploy-faucet branch 3 times, most recently from 65602b9 to c11c6ec Compare April 24, 2025 17:20
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/faucet branch 2 times, most recently from 32a4715 to f8c945c Compare April 28, 2025 13:16
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/deploy-faucet branch 3 times, most recently from 173f66c to 0eb425d Compare May 1, 2025 13:39
@norswap norswap changed the base branch from gabriel/faucet to graphite-base/668 May 2, 2025 23:16
@GabrielMartinezRodriguez GabrielMartinezRodriguez changed the base branch from graphite-base/668 to gabriel/faucet May 5, 2025 10:23
Base automatically changed from gabriel/faucet to master May 5, 2025 10:32
@GabrielMartinezRodriguez GabrielMartinezRodriguez merged commit 4f19ff4 into master May 5, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez deleted the gabriel/deploy-faucet branch May 5, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-blocked Ready to merge, waiting for downstack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants