-
Notifications
You must be signed in to change notification settings - Fork 2
TXM: Rpc liveness #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
TXM: Rpc liveness #562
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a5ca61d
feat(txm): rpc liveness
GabrielMartinezRodriguez 1f8449d
feat(txm): added hooks to notify when rpc liveness changes+
GabrielMartinezRodriguez 7c9da01
feat(txm): added livenessCheckInterval
GabrielMartinezRodriguez 032d0c0
chore(txm): pr review
GabrielMartinezRodriguez 325dcca
chore(txm): added test for RpcLivenessMonitor
GabrielMartinezRodriguez 6e8a7ed
chore(txm): increase hook timeout
GabrielMartinezRodriguez b2f9c57
chore(txm): fix tests
GabrielMartinezRodriguez c884815
chore(txm): implemented a counter for every second in the rpc livenes…
GabrielMartinezRodriguez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| import { LogTag, Logger } from "@happy.tech/common" | ||
| import { Topics } from "./EventBus" | ||
| import { eventBus } from "./EventBus" | ||
| import type { TransactionManager } from "./TransactionManager" | ||
| import { TxmMetrics } from "./telemetry/metrics" | ||
|
|
||
| interface SecondCounters { | ||
| successCount: number | ||
| errorCount: number | ||
| } | ||
|
|
||
| export class RpcLivenessMonitor { | ||
| private txmgr: TransactionManager | ||
| private counters: Record<number, SecondCounters> | ||
| public isAlive: boolean | ||
| private isDownSince: Date | null | ||
| private checkIfHealthyInterval: NodeJS.Timer | null | ||
| private consecutiveSuccessesWhileCheckingIfHealthy: number | ||
|
|
||
| constructor(txmgr: TransactionManager) { | ||
| this.txmgr = txmgr | ||
| this.counters = {} | ||
| this.isAlive = true | ||
| this.isDownSince = null | ||
| this.checkIfHealthyInterval = null | ||
| this.consecutiveSuccessesWhileCheckingIfHealthy = 0 | ||
| TxmMetrics.getInstance().rpcLivenessMonitorGauge.record(this.isAlive ? 1 : 0) | ||
|
|
||
| setInterval(() => { | ||
| this.cleanOldCounters() | ||
| }, 1000) | ||
| } | ||
|
|
||
| private getCurrentSecond(): number { | ||
| return Math.floor(Date.now() / 1000) | ||
| } | ||
|
|
||
| private cleanOldCounters(): void { | ||
| const now = this.getCurrentSecond() | ||
| const oldestAllowedSecond = now - Math.floor(this.txmgr.livenessWindow / 1000) | ||
|
|
||
| Object.keys(this.counters).forEach((secondStr) => { | ||
| const second = Number.parseInt(secondStr, 10) | ||
| if (second < oldestAllowedSecond) { | ||
| delete this.counters[second] | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| trackSuccess() { | ||
| const currentSecond = this.getCurrentSecond() | ||
|
|
||
| if (!this.counters[currentSecond]) { | ||
| this.counters[currentSecond] = { successCount: 0, errorCount: 0 } | ||
| } | ||
|
|
||
| this.counters[currentSecond].successCount++ | ||
| this.checkIfDown() | ||
| } | ||
|
|
||
| trackError() { | ||
| const currentSecond = this.getCurrentSecond() | ||
|
|
||
| if (!this.counters[currentSecond]) { | ||
| this.counters[currentSecond] = { successCount: 0, errorCount: 0 } | ||
| } | ||
|
|
||
| this.counters[currentSecond].errorCount++ | ||
| this.checkIfDown() | ||
| } | ||
|
|
||
| private checkIfDown() { | ||
| if (this.isAlive && this.ratioOfSuccess() < this.txmgr.livenessThreshold) { | ||
| this.isAlive = false | ||
| this.isDownSince = new Date() | ||
| this.consecutiveSuccessesWhileCheckingIfHealthy = 0 | ||
| this.updateLivenessMetrics() | ||
| eventBus.emit(Topics.RpcIsDown) | ||
| Logger.instance.error(LogTag.TXM, "Detected that the RPC is not healthy") | ||
|
|
||
| this.checkIfHealthyInterval = setInterval(() => { | ||
| this.checkIfHealthy() | ||
| }, this.txmgr.livenessCheckInterval) | ||
| } | ||
| } | ||
|
|
||
| private async checkIfHealthy() { | ||
| if (this.isDownSince && this.isDownSince.getTime() + this.txmgr.livenessDownDelay > new Date().getTime()) { | ||
| return | ||
| } | ||
|
|
||
| const chainIdResult = await this.txmgr.viemClient.safeGetChainId() | ||
|
|
||
| if (chainIdResult.isOk()) { | ||
| this.consecutiveSuccessesWhileCheckingIfHealthy++ | ||
| } else { | ||
| this.consecutiveSuccessesWhileCheckingIfHealthy = 0 | ||
| } | ||
|
|
||
| if (this.consecutiveSuccessesWhileCheckingIfHealthy > this.txmgr.livenessSuccessCount) { | ||
| Logger.instance.info(LogTag.TXM, "Detected that the RPC is healthy") | ||
| this.isAlive = true | ||
| this.isDownSince = null | ||
| this.consecutiveSuccessesWhileCheckingIfHealthy = 0 | ||
| this.counters = {} | ||
| this.updateLivenessMetrics() | ||
| eventBus.emit(Topics.RpcIsUp) | ||
| if (this.checkIfHealthyInterval) { | ||
| clearInterval(this.checkIfHealthyInterval) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| updateLivenessMetrics() { | ||
| TxmMetrics.getInstance().rpcLivenessMonitorGauge.record(this.isAlive ? 1 : 0) | ||
| } | ||
|
|
||
| ratioOfSuccess() { | ||
| let totalSuccesses = 0 | ||
| let totalEvents = 0 | ||
|
|
||
| Object.values(this.counters).forEach((counter) => { | ||
| totalSuccesses += counter.successCount | ||
| totalEvents += counter.successCount + counter.errorCount | ||
| }) | ||
|
|
||
| return totalEvents > 0 ? totalSuccesses / totalEvents : 1 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to add a unit test for this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it's a good thing to test. I'm going to implement one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test added