Skip to content

Fix package metadata and release workflow#2

Merged
bhavishyachandra merged 4 commits into
masterfrom
fix/newtonsoft-deps
May 20, 2026
Merged

Fix package metadata and release workflow#2
bhavishyachandra merged 4 commits into
masterfrom
fix/newtonsoft-deps

Conversation

@bhavishyachandra

Copy link
Copy Markdown
Contributor

This PR updates the package and release metadata so NuGet publishing matches the intended release state.

Summary:

  • update the package version and release notes to 1.4.4
  • derive the NuGet publish version from the pushed tag or a manual workflow input
  • switch README screenshots to trusted raw GitHub image URLs for NuGet rendering
  • remove the direct Newtonsoft.Json package reference so dependency flow matches Hangfire.Core
  • keep the related source/test cleanup included in the branch changes

Validation:

  • dotnet pack succeeded and the generated package no longer declares Newtonsoft.Json directly
  • dotnet test passed for net8.0 (122 tests)
  • net472 test execution is not runnable in this container because mono is not installed

Copilot AI review requested due to automatic review settings May 20, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Hangfire.Console’s packaging metadata and NuGet publish workflow so the published NuGet version matches the release tag (or an explicit manual input), while also making the README images render reliably on NuGet.org and aligning dependencies with Hangfire.Core.

Changes:

  • Bump package metadata to 1.4.4 and add corresponding release notes; remove the direct Newtonsoft.Json reference from the .NET Framework-specific item group.
  • Update the NuGet publish GitHub Actions workflow to resolve the package version from either a tag (v*) or a workflow_dispatch input, and pass it into dotnet build/pack.
  • Update README screenshots to use raw.githubusercontent.com URLs for NuGet rendering.

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Hangfire.Console.Tests/States/ConsoleApplyStateFilterFacts.cs Whitespace/formatting-only adjustments in tests.
tests/Hangfire.Console.Tests/Server/ConsoleServerFilterFacts.cs Minor formatting cleanup in tests.
tests/Hangfire.Console.Tests/ConsoleExtensionsFacts.cs Minor formatting cleanup in tests.
src/Hangfire.Console/Hangfire.Console.csproj Version bump to 1.4.4, release notes update, and removal of direct Newtonsoft.Json package reference for net451.
src/Hangfire.Console/Dashboard/ConsoleRenderer.cs Formatting-only change in regex literal and whitespace.
README.md Switch image links to trusted raw GitHub URLs for NuGet README rendering.
.github/workflows/publish-nuget.yml Resolve package version from tag or manual input and use it for build/pack during publishing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bhavishyachandra bhavishyachandra merged commit 7310d6f into master May 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants