Fix package metadata and release workflow#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Hangfire.Console’s packaging metadata and NuGet publish workflow so the published NuGet version matches the release tag (or an explicit manual input), while also making the README images render reliably on NuGet.org and aligning dependencies with Hangfire.Core.
Changes:
- Bump package metadata to 1.4.4 and add corresponding release notes; remove the direct
Newtonsoft.Jsonreference from the .NET Framework-specific item group. - Update the NuGet publish GitHub Actions workflow to resolve the package version from either a tag (
v*) or aworkflow_dispatchinput, and pass it intodotnet build/pack. - Update README screenshots to use
raw.githubusercontent.comURLs for NuGet rendering.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/Hangfire.Console.Tests/States/ConsoleApplyStateFilterFacts.cs |
Whitespace/formatting-only adjustments in tests. |
tests/Hangfire.Console.Tests/Server/ConsoleServerFilterFacts.cs |
Minor formatting cleanup in tests. |
tests/Hangfire.Console.Tests/ConsoleExtensionsFacts.cs |
Minor formatting cleanup in tests. |
src/Hangfire.Console/Hangfire.Console.csproj |
Version bump to 1.4.4, release notes update, and removal of direct Newtonsoft.Json package reference for net451. |
src/Hangfire.Console/Dashboard/ConsoleRenderer.cs |
Formatting-only change in regex literal and whitespace. |
README.md |
Switch image links to trusted raw GitHub URLs for NuGet README rendering. |
.github/workflows/publish-nuget.yml |
Resolve package version from tag or manual input and use it for build/pack during publishing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the package and release metadata so NuGet publishing matches the intended release state.
Summary:
Validation: