Modernize dependencies, CI, and branding#1
Merged
Conversation
bhavishyachandra
changed the title
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Hangfire.Console repo by updating core/test dependencies, migrating CI/publishing from AppVeyor to GitHub Actions, and aligning JSON serialization usage with newer Hangfire APIs.
Changes:
- Update Hangfire.Core and related serialization usage (move from
JobHelper.ToJson/FromJson+ explicit Json.NET settings toHangfire.Common.SerializationHelper). - Retarget and update test dependencies (multi-target tests on
net472;net8.0, newer xUnit/Moq/Test SDK). - Replace AppVeyor with GitHub Actions workflows for CI and NuGet publishing; update README badges accordingly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Hangfire.Console.Tests/Storage/ConsoleStorageFacts.cs | Updates test stubs to serialize ConsoleLine using SerializationHelper. |
| tests/Hangfire.Console.Tests/Hangfire.Console.Tests.csproj | Multi-targets tests (net472;net8.0) and bumps test package versions. |
| tests/Hangfire.Console.Tests/Dashboard/JobProgressDispatcherFacts.cs | Switches JSON serialization assertion to SerializationHelper. |
| src/Hangfire.Console/Storage/ConsoleStorage.cs | Uses SerializationHelper for storing and reading console lines. |
| src/Hangfire.Console/Hangfire.Console.csproj | Updates TFMs and dependency versions (notably Hangfire.Core/Newtonsoft.Json). |
| src/Hangfire.Console/Dashboard/JobProgressDispatcher.cs | Removes explicit Json.NET settings and serializes response via SerializationHelper. |
| README.md | Replaces AppVeyor badge with GitHub Actions CI/publish badges. |
| Hangfire.Console.sln | Removes AppVeyor config from Solution Items. |
| appveyor.yml | Deletes legacy AppVeyor pipeline configuration. |
| .github/workflows/ci.yml | Adds GitHub Actions CI workflow (restore/build/test/pack). |
| .github/workflows/publish-nuget.yml | Adds GitHub Actions tag-based NuGet publish workflow using OIDC login. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
125
to
129
| <ItemGroup Condition=" '$(TargetFramework)' == 'net45' "> | ||
| <Reference Include="System" /> | ||
| <Reference Include="Microsoft.CSharp" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="5.0.1" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.4" /> | ||
| </ItemGroup> |
Comment on lines
1
to
12
| using System.Collections.Generic; | ||
| using Hangfire.Common; | ||
| using Hangfire.Console.Dashboard; | ||
| using Newtonsoft.Json; | ||
| using Xunit; | ||
|
|
||
| namespace Hangfire.Console.Tests.Dashboard | ||
| { | ||
| public class JobProgressDispatcherFacts | ||
| { | ||
| [Fact] | ||
| public void JsonSettings_PreservesDictionaryKeyCase() | ||
| public void Serialize_PreservesDictionaryKeyCase() | ||
| { |
Comment on lines
+31
to
+34
| run: dotnet test tests/Hangfire.Console.Tests/Hangfire.Console.Tests.csproj -c Release --no-build | ||
|
|
||
| - name: Pack | ||
| run: dotnet pack src/Hangfire.Console/Hangfire.Console.csproj -c Release --no-build -o artifacts No newline at end of file |
Comment on lines
+31
to
+34
| run: dotnet test tests/Hangfire.Console.Tests/Hangfire.Console.Tests.csproj -c Release --no-build | ||
|
|
||
| - name: Pack | ||
| run: dotnet pack src/Hangfire.Console/Hangfire.Console.csproj -c Release --no-build -o artifacts /p:ContinuousIntegrationBuild=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency matrix, moves CI and publishing to GitHub Actions, and switches the repository/package metadata to Hangtools.
Changes:
Validation: