Skip to content

fix(spec): correct two stale file references found in the spec audit #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyluslosius merged 1 commit into from
Jun 15, 2026
+11 −8
Merged

fix(spec): correct two stale file references found in the spec audit #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions specs/agent/handler-port-filepermissions.spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,15 @@ spec:
always false (the agent IS the target), Close
no-op.

2. `internal/agent/remotehandler/remotehandler.go`
— controller-side shim wrapping
`*client.Client` + a mechanism name; satisfies
`api.Handler`, `api.CaptureHandler`,
`api.RollbackHandler` by forwarding to
client.Apply/Capture/Rollback. The
2. The controller-side shim, implemented as
`agentBackedHandler` in
`internal/engine/engine.go` (returned by
`engine.lookupHandler` when an AgentClient is
set, NOT a separate `internal/agent/remotehandler`
package) — wraps the engine's `AgentClient` + a
mechanism name; satisfies `api.Handler`,
`api.CaptureHandler`, `api.RollbackHandler` by
forwarding to client.Apply/Capture/Rollback. The
`transport` argument the engine passes is
ignored (the agent runs locally on the
target; it doesn't use a controller-supplied
Expand Down Expand Up @@ -119,7 +122,7 @@ spec:
scope:
includes:
- "internal/agent/transport/local/local.go + _test.go"
- "internal/agent/remotehandler/remotehandler.go + _test.go"
- "internal/engine/engine.go: agentBackedHandler (the agent-routing handler shim, via lookupHandler) + _test.go"
- "internal/agent/server/server.go + _test.go"
- "internal/engine/engine.go: WithAgentClient option"
- "cmd/kensa/main.go: agent-mode-default (KENSA_NO_AGENT opt-out) path"
Expand Down
2 changes: 1 addition & 1 deletion specs/evidence/envelope.spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ spec:
# not yet written. Future deliverable: schema-codegen +
# round-trip test.
# - AC-10 (cross-repo schema match between kensa-spec/yaml
# and api/envelope.go Go struct):
# and the api.EvidenceEnvelope Go struct in api/transaction.go):
# Requires a cross-repo schema comparison step
# (`go generate` or CI check). Tracked in
# SPECTER_FEATURE_REQUEST.md.
Expand Down