[core][build] A collection of small detailed fixes and cleanups#3333
Open
ethouris wants to merge 7 commits into
Open
[core][build] A collection of small detailed fixes and cleanups#3333ethouris wants to merge 7 commits into
ethouris wants to merge 7 commits into
Conversation
This was referenced Jun 11, 2026
added 6 commits
June 15, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important changes:
configurescript exposed CMAKE_CXX_COMPILER cmake variable only if--with-compiler-typeoption was provided; that should be done also if--with-compiler-prefixwas added.falseanyway, but some gcc compilers choke on this (those with not-full-support of C++11).