[core] Using simplified closing a socket on fork cleanup to prevent potential deadlocks#3330
Open
ethouris wants to merge 1 commit into
Open
[core] Using simplified closing a socket on fork cleanup to prevent potential deadlocks#3330ethouris wants to merge 1 commit into
ethouris wants to merge 1 commit into
Conversation
…otential deadlocks
ethouris
added
Type: Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3326
Problem: The call to
fork()may potentially catch the SRT library in the state with several active connections; in this case the forked-off version may be caught with some mutexes being locked forever. One of them is in use by the function that tries to close all sockets before deleting them. Therefore there's a special simplified version of closing that ignores the part that requires cleanup for any inter-connection data - stating that still every socket will be eventually closed and deleted anyway.