fix: return empty/null on 204 No Content and empty response bodies#1
Merged
Conversation
Get* methods that returned collections (GetComputersAsync,
GetProductsAsync, GetWebhooksAsync, GetWebhookDeliveriesAsync) called
ReadFromJsonAsync unconditionally and threw
System.Text.Json.JsonException ("The input does not contain any JSON
tokens") when the server returned HTTP 204 No Content or HTTP 200 with
an empty body. The /api/computer/all endpoint returns 204 for receipts
with zero attached computers, which crashed consumers that called
GetComputersAsync.
Centralize the guard in two helpers (ReadJsonOrDefaultAsync<T>,
ReadJsonOrEmptyAsync<T>) and route every affected Get* method through
them so future endpoints inherit the fix.
Add an xUnit test project (LicenseManagement.Client.Tests) covering 204
and empty-body cases for the collection-returning Get* methods and the
single-item GetComputerAsync.
Bumps package version to 1.2.1 (patch).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get* methods that returned collections (GetComputersAsync, GetProductsAsync, GetWebhooksAsync, GetWebhookDeliveriesAsync) called ReadFromJsonAsync unconditionally and threw
System.Text.Json.JsonException ("The input does not contain any JSON tokens") when the server returned HTTP 204 No Content or HTTP 200 with an empty body. The /api/computer/all endpoint returns 204 for receipts with zero attached computers, which crashed consumers that called GetComputersAsync.
Centralize the guard in two helpers (ReadJsonOrDefaultAsync, ReadJsonOrEmptyAsync) and route every affected Get* method through them so future endpoints inherit the fix.
Add an xUnit test project (LicenseManagement.Client.Tests) covering 204 and empty-body cases for the collection-returning Get* methods and the single-item GetComputerAsync.
Bumps package version to 1.2.1 (patch).